petefoth
commented
2 months ago Thanks for this - merged
Closed FintasticMan closed 2 months ago
petefoth
commented
2 months ago Thanks for this - merged
gwstorm
commented
2 months ago These changes also mean that the error faced by @gwstorm is fixed.
Thanks for all of this work, guys. Indeed, I got past the build script error. The build is failing later on, but I don't think it has anything to do with the any of the work being done here.
FintasticMan
commented
2 months ago For the moment, you need to disable the SIGNATURE_SPOOFING option (and I would recommend disabling it in future as well).
gwstorm
commented
2 months ago Understood. I'll keep it disabled. Same error though,
Assuming it's still unrelated.
petefoth
commented
2 months ago Understood. I'll keep it disabled. Same error though, Error
Assuming it's still unrelated.
The part of the log files you pasted does not show where the error occurred or when it occurred. To find that out, you need to search in the log file for the string FAILED:. The line before that is the command that failed, and subsequent lines, down to the next % progress line give details of the error. That's what you need to look at - or post here - to find the cause of the error
There will be a lot of text in the log file after the error occurs. This is because there are several build tasks running concurrently in different threads and the build won't stop until all those threads complete. One of the threads is probably Building Kernel Image. This task produces lots of log output which is not written to the log until the thread completes, usually some time after the FAILED command. So the stuff in your paste from the log, from
INSTALL techpack/datarmnet/core/rmnet_core.ko
down to
>> [Wed Apr 24 23:28:25 UTC 2024] Cleaning source dir for device lemonadep
Is output from the Building Kernel Image task and not from the failed command
gwstorm
commented
2 months ago Got it. Definitely learning a lot about this now. If this is off topic and better suited for its own issue, let me know.
FintasticMan
commented
2 months ago Looks like your drive isn't big enough. Might be something else as well though.
petefoth
commented
2 months ago Looks like your drive isn't big enough. Might be something else as well though.
It's nothing to do with the machine being used to build, it's to do with the space available in the syetem_ext partition on the device being built for.
The max image size for filesystem files is 408571904 bytes (389 MB), out of a total partition size of 408571904 bytes (389 MB)du -h out/target/product/sunfish/system_ext/ gives 399MPlease can we continue discussion in #616 - this problem is nothing to do with signature spoofing - it occurs when "SIGNATURE_SPOOFING=no" and when building with the master branch (without any of the recent PRs)
This restores the (still currently non-functional) Android 14 signature spoofing patches, so that, once they have been fixed, users will be able to create unrestricted patches.
These changes also mean that the error faced by @gwstorm is fixed.
If these are merged, the
nns-v21-spoofing-patchesbranch no longer has any loss of functionality compared to master, and only improves compatibility. Therefore I believe that it should be able to be merged into master.After (or before, but then there could be merge conflicts) that, we can focus on fixing the patches so that they work. I see you've already started work on that, thank you!