add missing tickets variable

[PavelLinearB]

[gitstream-cm[bot]]

• Added a new section called tickets to capture Jira ticket IDs within a list.
• The tickets section extracts ticket IDs from both the branch name and the PR title using a regular expression.
• This change aims to streamline the process of identifying Jira ticket IDs from available sources in the context of a pull request.

[gitstream-cm[bot]]

1. Finding Bugs, Security Risks, and Performance Issues:

   • The capture function with regex is used to extract ticket information from branch names and PR titles. Ensure there's no potential for regex injection, although the risk seems minimal given the controlled input sources (branch names and PR titles). However, it's good practice to validate the source of these inputs and sanitize them where possible.
   • Validate and verify that the webhook URL (JIRA_UPDATE_PR_FIELD_WEBHOOK) is secured and correctly configured to accept POST requests. Ensure HTTPS is used to prevent interception.
   • Check that ticketid from the capture is correctly escaped or validated before being included in the HTTP request body to avoid injection attacks if this script is modifiable by the end-user or if further processing happens.

2. Verify Best Practices and Style Guide Violations:

   • The logic attempts to extract ticket IDs from both branch names and PR titles. Ensure consistency in naming conventions across your repository and JIRA to minimize errors in ticket capturing.
   • Consider checking if only one valid ticket ID should be captured per PR to avoid issues with which ticket ID takes precedence (in this change, PR title's ticket ID may override the branch's if both exist).

3. Specific Improvement Suggestions Based on the Changes:

   • The tickets list contains both branch name and PR title captures. Ensure this doesn't lead to duplicate operations or possible unintended updates by double-checking the captured output in other calls or logic downstream.
   • Consider logging or notifying the operation results for audit and transparency purposes, particularly for successful or failed requests, which could be helpful for debugging any configuration errors.
   • Review any error handling mechanisms to ensure the system can handle failures gracefully when the HTTP request to the JIRA webhook fails.

No style violations were notable, but ensure that YAML spacing and indentation are consistent according to your project's guidelines.