search

linebender / bevy_vello

An integration to render with Vello in Bevy game engine.
https://linebender.org/bevy_vello/
Apache License 2.0
117 stars 12 forks source link

enhancement: Use `SpatialBundle` inside our bundles #44

Closed simbleau closed 3 months ago

simbleau commented 3 months ago

Currently we have transforms, global transforms, visibility, etc. inlined into each bundle (VelloSceneBundle, VelloAssetBundle, VelloTextBundle).

We should take the approach of splined and perhaps inline the SpatialBundle instead.

cpetzold commented 3 months ago

I go back and forth on it -- it's nice to simplify the code but the UX suffers a little bit needing to now nest into SpatialBundle for customizing its components.

simbleau commented 3 months ago

Wondering if there's a macro to flatten it, like #[serde(flatten)]?

cpetzold commented 3 months ago

By the way I asked this on the Bevy discord a while ago: https://discord.com/channels/691052431525675048/742569353878437978/1145869833729216583

Looks like the conclusion I came to there is that inlining the components is nice to mirror native bundles like SpriteBundle.

simbleau commented 3 months ago

Since it appears to be the convention... we'll keep as is. Won't do.