It seems that we can rather easily upgrade to Rust 2021 and there is currently a direct benefit, so I think we should do it. Specifically clippy 1.67 (beta) is buggy with Rust 2018 as I found out in #2326. Upgrading to Rust 2021 will solve that issue for us.
There is an exception in druid-derive which will remain Rust 2018. We have macros that use syntax which is no longer allowed in Rust 2021.
This is mostly relevant to macros. E.g. quote!{ #a#b } is no longer accepted.
It seems that we can rather easily upgrade to Rust 2021 and there is currently a direct benefit, so I think we should do it. Specifically clippy 1.67 (beta) is buggy with Rust 2018 as I found out in #2326. Upgrading to Rust 2021 will solve that issue for us.
There is an exception in
druid-derive
which will remain Rust 2018. We have macros that use syntax which is no longer allowed in Rust 2021.As
druid-derive
doesn't have anyassert!
ordebug_assert!
usage that clippy complains about, staying at 2018 there isn't an issue for us right now.