windows: Fix not linking against shell32 lib.

linebender / glazier

Deprecated Rust Window Creation Library

Apache License 2.0

206 stars 32 forks source link

windows: Fix not linking against shell32 lib. #157

Closed waywardmonkeys closed 1 year ago

waywardmonkeys commented 1 year ago

Fixes #156.

waywardmonkeys commented 1 year ago

We should add an example that doesn't pull in any other dependencies so that we catch this in CI in the future.

If someone approves this, feel free to merge it. I'm gone for the next 12-ish hours.

waywardmonkeys commented 1 year ago

Unfortunately, the current situation is that there can be a link failure if one of your other deps doesn’t enable this feature. Technically, this is a bug in winapi, I think that it doesn’t correctly enable this when some other feature needs it. Looking forward to changing to windows-sys!