search

linebender / glazier

Deprecated Rust Window Creation Library
Apache License 2.0
206 stars 32 forks source link

MouseButton variants should be named Primary/Secondary instead of Left/Right/Middle #88

Closed lord closed 1 year ago

lord commented 1 year ago

TimTom on Zulip points out that the official spec doesn't say Left/Right because some users swap their primary mouse button; we should probably change these variant names to match the spec.

richard-uk1 commented 1 year ago

This sounds good to me, but we should discuss at the Office hours.

jneem commented 1 year ago

I'm fine with discussing this in office hours, but I think that in general we should make decisions here on the GitHub issues: there's a better record of discussion, and the async format might be easier for some people.

On Sun, Apr 23, 2023, 16:43 Richard Dodd (dodj) @.***> wrote:

This sounds good to me, but we should discuss at the Office hours.

— Reply to this email directly, view it on GitHub https://github.com/linebender/glazier/issues/88#issuecomment-1519175348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBRMNMFZV2GPCSR5I5YHTXCWO7LANCNFSM6AAAAAAXIQQSVQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jneem commented 1 year ago

Discussed in office hours, and everyone was fine with the renaming. :heavy_check_mark: