search

linebender / norad

Rust crate for working with Unified Font Object files
Apache License 2.0
44 stars 12 forks source link

Errors: use https://lib.rs/crates/thiserror to reduce description duplication? #204

Closed madig closed 2 years ago

madig commented 2 years ago

The doc updates sorta duplicate the meaning of the error message in the docstring and the Display trait. Should we use thiserror in norad?

madig commented 2 years ago

Experimental PR at https://github.com/linebender/norad/pull/211.

cmyr commented 2 years ago

looking into this I think it's a good idea, and generates the same code we would get if we were hand-writing things.