search

linebender / norad

Rust crate for working with Unified Font Object files
Apache License 2.0
43 stars 12 forks source link

Rename `LayerSet` to `LayerContents` & clarify ordering #329

Closed RickyDaMa closed 11 months ago

RickyDaMa commented 12 months ago

Will close #326

Documentation also now explicitly states the layers are ordered

If we were interested in maintaining backwards compatibility, we could do a re-export under the old name:

#[deprecated(
    note = "old naming convention, switch to LayerContents instead",
    since = "0.12.2",
)]
pub use LayerContents as LayerSet;
cmyr commented 12 months ago

I'm happy either way, I'm not sure we have enough outside users to be too concerned about the breakage, but if you're feeling extra kind you should feel free, in which case I'd probably simplify the deprecation message to just "renamed to LayerContents" (but anything is fine really)

RickyDaMa commented 11 months ago

Let's save ourselves the hassle of removing it later then 😄