search

linebender / norad

Rust crate for working with Unified Font Object files
Apache License 2.0
43 stars 12 forks source link

Remove usages of `extern crate` syntax. #351

Closed waywardmonkeys closed 2 months ago

RickyDaMa commented 2 months ago

Would this also mean that we can remove this dependency from the Cargo.toml?

https://github.com/linebender/norad/blob/9f0f512b3bba8d888fef569552c3a644fd7d6492/Cargo.toml#L30

Thanks for your continual efforts to modernise the repo; is there a particular motivation behind this PR beyond just bringing norad more up-to-date?

waywardmonkeys commented 2 months ago

Would this also mean that we can remove this dependency from the Cargo.toml?

No ... that's what makes it available for use. Just that since Rust 2018 edition, the extern crate is no longer needed, just having it in the Cargo.toml is enough.

Thanks for your continual efforts to modernise the repo; is there a particular motivation behind this PR beyond just bringing norad more up-to-date?

Sadly, no! I just help out on a bunch of the linebender repos and this is in the linebender organization!

I don't even know what UFO files are (beyond what the readme says).

RickyDaMa commented 2 months ago

Would this also mean that we can remove this dependency from the Cargo.toml?

No ... that's what makes it available for use.

My bad, I completely missed the usages of serde_repr's macros in the source code, I thought it might have been an unused dependency

Thanks for your time!