Open PoignardAzur opened 3 weeks ago
We should add a standardized set of rustc lints and clippy lints to all our projects. If we raise MSRV to 1.74, we can add them directly to Cargo.toml.
Cargo.toml
See zulip discussion for what our lint set should be. See https://github.com/linebender/peniko/pull/47/ for our current lint set.
Aside from the Cargo.toml lints, we should also add the following annotation to our crate root:
#![warn(clippy::print_stdout, clippy::print_stderr, clippy::dbg_macro)]
(We don't want a workspace-level lints for those because we want to tolerate prints in tests and examples.)
See this zulip thread for details.
We should add the following annotation at the crate roots:
We should also remove leftover prints, if any, or give them an opt-out.
See https://github.com/linebender/linebender.github.io/pull/68
PoignardAzur
commented
1 week ago
We should add a standardized set of rustc lints and clippy lints to all our projects. If we raise MSRV to 1.74, we can add them directly to
Cargo.toml.See zulip discussion for what our lint set should be. See https://github.com/linebender/peniko/pull/47/ for our current lint set.
Aside from the
Cargo.tomllints, we should also add the following annotation to our crate root:(We don't want a workspace-level lints for those because we want to tolerate prints in tests and examples.)
See this zulip thread for details.
We should add the following annotation at the crate roots:
We should also remove leftover prints, if any, or give them an opt-out.