search

linebender / parley

Rich text layout library
Apache License 2.0
228 stars 28 forks source link

Use `arboard` instead of `clipboard_rs` in `vello_editor` example #175

Closed nicoburns closed 3 days ago

nicoburns commented 5 days ago

clipboard_rs is unmaintained and also unnecessarily pulls in every image format from the image crate. This PR switches to the arboard crate which is a maintained fork of clipboard_rs (and seems to be the most popular fork, although there is not currently one clear "winner" in this space)

waywardmonkeys commented 5 days ago

I think you've confused clipboard-rs with clipboard. clipboard-rs is maintained with a release only 2 months ago and the author merged some PRs of mine last month.

I had a commit locally to submit to clean up the image dependency, but I see that I forgot to do so. I've updated and submitted it now: https://github.com/ChurchTao/clipboard-rs/pull/53

Let's give him a shot at responding this week.

If we do end up going and merging this, you'll need to edit your PR description to be accurate.

xorgy commented 4 days ago

I was wondering why we were building rav1e in vello_editor...

waywardmonkeys commented 3 days ago

I coordinated with upstream and a new release of clipboard-rs is out that uses fewer image features.

nicoburns commented 3 days ago

Right, I guess we can close this then.