search

linebender / parley

Rich text layout library
Apache License 2.0
158 stars 18 forks source link

Migrate to multi-crate layout. #59

Closed waywardmonkeys closed 1 month ago

waywardmonkeys commented 1 month ago

This moves all parley items into a subdirectory next to fontique.

waywardmonkeys commented 1 month ago

This lacks a top level README.md as it seems like maybe there isn't a general template yet for this for Linebender repos.

@nicoburns I'd assumed that maybe examples would / could still live at the top level. Maybe I'm wrong!

xStrom commented 1 month ago

Yeah the top-level readme template isn't finalized. That said, I think it's fine to just keep a copy of the old top-level readme and update it separately from this PR.

waywardmonkeys commented 1 month ago

Okay, I've rebased on top now that the tiny-skia sample landed.

I'll fix the clippy thing with a separate PR and then rebase again.

waywardmonkeys commented 1 month ago

Yeah the top-level readme template isn't finalized. That said, I think it's fine to just keep a copy of the old top-level readme and update it separately from this PR.

For now, I did this and hopefully we can follow up quickly (a day or so?) with a better top level README.

waywardmonkeys commented 1 month ago

Hmm, guess I have to modify CI now ...

waywardmonkeys commented 1 month ago

Okay, I think I got the CI this time. I'd made the example use a workspace dependency on parley (that I added), but that didn't have default features enabled while the old build did. So now the example still uses that workspace dependency, but enables default-features.

waywardmonkeys commented 1 month ago

@nicoburns @DJMcNab If you could re-approve with that revision, that'd be great! And then I'll merge it!

DJMcNab commented 1 month ago

Looks like #63 might also fix this. @xStrom which should we land first?

waywardmonkeys commented 1 month ago

Looks like #63 might also fix this. @xStrom which should we land first?

That's fixing a separate issue ... my problem in this one with CI was just my own brain damage, corrected now. :)