search

linebender / parley

Rich text layout library
Apache License 2.0
158 stars 18 forks source link

Move `unused_qualifications` to the lints table. #61

Closed xStrom closed 1 month ago

xStrom commented 1 month ago

We don't need to wait for MSRV support to use the lints table. The MSRV cargo check commands won't fail, they'll just warn that there is an unused manifest key but the CI will still pass. The stable toolchain will do the actual linting.

This won't be a problem for projects higher up the stack either, as Cargo doesn't complain about unused manifest keys of dependencies.

waywardmonkeys commented 1 month ago

Oh, we were already using the [lints] table?

I guess that's the danger of GitHub's condensed PR review view

Only in this crate, not in kurbo or peniko ... I'd noticed earlier today after merging it, but haven't had a spare moment since ...

Thanks, @xStrom !