search

linebender / parley

Rich text layout library
Apache License 2.0
209 stars 24 forks source link

fontique: Make `icu_properties` optional #72

Closed waywardmonkeys closed 4 months ago

waywardmonkeys commented 4 months ago

This doesn't seem like everyone using fontique will need this (or already have it in their dependency graph).

I left this in default since that's the current behavior, but I think there's a good case for not doing so.

dfrg commented 4 months ago

+1, thanks. I’m also fine with making this off by default and enabling the feature in parley if necessary.

waywardmonkeys commented 4 months ago

I'm going to wait and see if @dfrg thinks we should just remove it from the default features since I'm not in a rush.

waywardmonkeys commented 4 months ago

@dfrg parley doesn't need this feature to build / run. So I'll just remove it from the default features and people can enable if they find it useful?

dfrg commented 4 months ago

Removing from default sounds good to me.

waywardmonkeys commented 4 months ago

Updated with it removed from default features.