search

linebender / piet

An abstraction for 2D graphics.
Apache License 2.0
1.24k stars 93 forks source link

Fix trailing whitespace calculation for non-ascii space characters #428

Closed Majora320 closed 3 years ago

Majora320 commented 3 years ago

Closes #427

Majora320 commented 3 years ago

That failure is really weird, I tested the latest commit of this locally with wasm-pack and everything passed.

cmyr commented 3 years ago

@Majora320 okay the new impl is merged, feel free to try this again, and PR the test in any case!

Majora320 commented 3 years ago

Hm, looks like the threshold might need to be increased? Every test that's failing here works on my machine; I'm really confused about why the wasm-pack one is still failing especially.

Majora320 commented 3 years ago

Still fails on the wasm target; I thought it was because perhaps the CI machine doesn't have the proper font installed to display kanji, but if that's the case it doesn't have one for fullwidth characters either (?) Maybe a CI step to install a font for it?

cmyr commented 3 years ago

yes it's very possible that we're missing a font. In any case wasm is not a tier-one target and does not have the full text API, so I think it's fine to just disable this test on wasm for now, lots of text tests are disabled there.