Try to clarify docs for ImageFormat

psychon commented 3 years ago

The image format is based on individual bytes and thus independent of the system's endianness. This commit tries to make that more explicit.

This was originally suggested in issue #224.

Signed-off-by: Uli Schlachter psychon@znc.in

psychon commented 3 years ago

So, two weeks after opening a PR, I get a mail that the PR run failed. I don't think that's due to this PR and will just ignore this:

error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
Error:    --> piet/src/gradient.rs:212:15
    |
212 |     fn to_vec(self) -> Vec<GradientStop> {
    |               ^^^^
    |
    = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
    = help: consider choosing a less ambiguous name
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[...lots more stuff like this...]

cmyr commented 3 years ago

@psychon fixing these in #451, will merge that shortly and you can rebase.

cmyr commented 3 years ago

@psychon okay, these should be ready!

psychon commented 3 years ago

Rebased both PRs onto master

linebender / piet

Try to clarify docs for ImageFormat #449