feat(piet): add Debug,Clone,PartialEq impls to TextAttribute

linebender / piet

An abstraction for 2D graphics.

Apache License 2.0

1.24k stars 93 forks source link

feat(piet): add Debug,Clone,PartialEq impls to TextAttribute #485

Closed Fenex closed 2 years ago

Fenex commented 2 years ago

Issue #483 (extended, conflict with PR #484)

The PR adds Debug, Clone and PartialEq derives to TextAttribute.

cmyr commented 2 years ago

@Fenex just out of curiosity, do you have any particular need for PartialEq? I'm not sure if it's particularly helpful, so I might keep this to just Debug and Clone unless you have a particular case in mind. :)

Fenex commented 2 years ago

Mmm. In real I need Clone impl only. (:

Perhaps derive PartialEq is really useless for TextAttribte ... I don't know. I can force-push to this PR without the derive if you want (or open yet another PR :D ).