search

linebender / piet

An abstraction for 2D graphics.
Apache License 2.0
1.24k stars 93 forks source link

Update `foreign-types` to `0.5.0` #496

Closed avitex closed 2 years ago

avitex commented 2 years ago

Last of my deps update spam. Left this separate from the others :)

cmyr commented 2 years ago

Unfortunately iirc we can't update this dep, since one of our dependencies is stuck on the old version.

avitex commented 2 years ago

I'll work on that upstream first then!

cmyr commented 2 years ago

@avitex you're welcome to try, but I suspect it will be a lot of work and I'm not sure it's the best use of time. My ultimate conclusion was that we have a solution that works, and it wasn't worth making more work for ourselves. You are free to draw different conclusions of course!

I'm going to close this for the time being, but feel free to open again if you believe that there are no upstream conflicts. :)

avitex commented 2 years ago

I made a even more upstream PR https://github.com/sfackler/foreign-types/pull/17 Will reopen this if I manage to make it out of that hole :)

cmyr commented 2 years ago

good luck!