Open notgull opened 1 year ago
I haven't looked at the changes in any depth, but the CI failures should be resolved.
I can't replicate the failures locally
Is this still something you would like to see merged?
If so, then the current problem is that the CI seems to be stuck in 'waiting'. I think the best approach here is for you to rebase on master
and force push to your branch to re-trigger the CI for this PR. Thanks!
I still want this, it's just that I've been busy with more pressing issues.
I have no idea why the piet-core-graphics implementation is failing
@notgull #562 has a fix for the piet-coregraphics failures, but also bumps some dependencies.
I got that other failure once about local connections, but another time it went green so I'm not sure if that check is spurious or why exactly it finally went green for me.
As below, so above.
The main hiccup here is that I can't use
Box<dyn std::error::Error>
onno_std
, so I just make it so theBackendError
variant ofError
isn't there onno_std
. There is probably a more elegant solution to this problem.