Update kurbo and svg dependencies, fix a clippy warning.

linebender / piet

An abstraction for 2D graphics.

Apache License 2.0

1.23k stars 95 forks source link

Update kurbo and svg dependencies, fix a clippy warning. #562

Closed ratmice closed 6 months ago

ratmice commented 7 months ago

This updates to the latest kurbo, I could have a version which is compatible with both piet and vello...

Svg had a future incompatibility warning, upgrade to fix that.
Clippy noticed that font_kit::sources::MultiSource is !Send !Sync, So replace Arc<Mutex<MultiSource> with Rc<RefCell<_>>.

Not sure if this last bit is a wanted change, or if it'd be preferred to just silence the warning, or ignore it entirely?

ratmice commented 6 months ago

Yeah, perhaps it is better if I drop the version bumps to avoid the breaking changes? I didn't really end up using the library I wanted this version bump for, but it'd be good to get the lints updated regardless.

jneem commented 6 months ago

I don't think it's so bad to have the version bump, just as long as we're aware that it needs one. I think it makes sense to have a version of piet that's compatible with the latest version of kurbo, after all.