linebender / resvg

An SVG rendering library.
Mozilla Public License 2.0
2.79k stars 225 forks source link

Add benchmarks #826

Closed sorairolake closed 3 weeks ago

sorairolake commented 3 weeks ago

Benchmark tests available in nightly Rust, and this can be run as follows:

cargo +nightly bench

If it's acceptable to add this, I'll write it for resvg and usvg.

RazrFalcon commented 3 weeks ago

You can use bencher on stable just fine.

As for the benchmarks, the main reason we don't have them is that they would be sort of pointless. We cannot easily compare resvg performance with other libraries and measuring resvg performance on its own doesn't really make much sense, since we're not changing anything, so regressions are unlikely.

What is your goal with benchmarks? And what exactly are you plan to benchmark?

sorairolake commented 3 weeks ago

What is your goal with benchmarks? And what exactly are you plan to benchmark?

Because I thought it would be useful to be able to measure the performance of resvg and usvg.

But if this doesn't make much sense, this addition may not be necessary.

RazrFalcon commented 3 weeks ago

Sorry, but no. Not very useful.