linebender / runebender

A font editor written in Rust.
Apache License 2.0
765 stars 37 forks source link

[ui] Weird parantheses in "(edit)" button #253

Open felipesanches opened 3 years ago

felipesanches commented 3 years ago

Screenshot from 2021-07-01 15-16-23

I don't see a need for parantheses here. It could be simply "edit", or more verbosely, "Edit font properties"

Ideally, in my opinion, though, there should be no button at all. The font name should be clickable to access that menu (it should also change style on mouse hover as a hint to the user).

cmyr commented 3 years ago

This is definitely not intended long-term; the original idea was to have some icon here but we didn't have an easy way to implement icon buttons, and so this was added as a placeholder.

Similarly, the 'modal view' that pops up when you click this is also a hack, and I don't expect it to last longterm.