linemanjs / lineman-angular-template

A Lineman Application Template using AngularJS
251 stars 88 forks source link

Documentation: Incorrect reference to config/application.js in README.md? #37

Closed wanthony closed 10 years ago

wanthony commented 10 years ago

It appears as if there is an outdated reference to config/application.js in the README (when referencing config values to modify when developing with CoffeeScript).

Either config/application.js should be config/lineman.js, or the changes necessary for proper CoffeeScript usage should be modified (or so it seems, please correct me if I'm wrong).

searls commented 10 years ago

Not sure what you're referring to, but config/application.js (or .coffee), is indeed a correct place to override lineman default values. 

config/lineman.js is simply a convenience shim for requiring the lineman object as your project would actually see it (in case you have any node scripts that might use it).

On Wed, Mar 19, 2014 at 12:10 AM, Anthony White notifications@github.com wrote:

It appears as if there is an outdated reference to config/application.js in the README (when referencing config values to modify when developing with CoffeeScript).

Either config/application.js should be config/lineman.js, or the changes necessary for proper CoffeeScript usage should be modified (or so it seems, please correct me if I'm wrong).

Reply to this email directly or view it on GitHub: https://github.com/linemanjs/lineman-angular-template/issues/37

wanthony commented 10 years ago

@searls I believe the code snippet in the CoffeeScript configuration section is a little off, then. Check out what's actually in config/application.js vs. what the code sinppet provides. It looks like it's a mix of config/application.js and the config/lineman.js shim.

wanthony commented 10 years ago

:+1: