search

linemanjs / lineman

Lineman helps you build fat-client JavaScript apps. It produces happiness by building assets, mocking servers, running specs on every file change
MIT License
1.18k stars 82 forks source link

Added lineman deploy command for new deployment plugin support #199

Closed jraede closed 9 years ago

jraede commented 10 years ago

Did this fail due to anything I did? Nothing in the app directory was changed so it shouldn't have affected the watch task...

searls commented 10 years ago

No the build is currently erratic. Need to fix that. My bad for worrying you!

On Tue, Feb 4, 2014 at 2:52 PM, Jason Raede notifications@github.com wrote:

Did this fail due to anything I did? Nothing in the app directory was changed so it shouldn't have affected the watch task...

Reply to this email directly or view it on GitHub: https://github.com/linemanjs/lineman/pull/199#issuecomment-34099525

jasonkarns commented 10 years ago

We use travis ci as a make-shift Chaos Monkey, but for emotions instead of infrastructure.

searls commented 10 years ago

Hey @jraede -- I'm really sorry for not getting back to you a full week later, between travel and catch-up this got pushed a couple dozen yaks down the stack. I have not forgotten you!

searls commented 10 years ago

Hey @jraede -- heads up that the project uses 2-space indents. I'll tidy it up as I review it this morning

searls commented 10 years ago

By the way @jraede -- don't feel like you have to push up fixes to any of my nitpicks that I'm adding in the line comments -- more valuable to me is for you to raise alarm where you think my feedback might be misguided or incorrect in a reply

searls commented 10 years ago

Well @jraede thanks for the rousing code review session! I feel pretty good about where we landed. I'm going to take a stab at implementing this tonight or Tuesday with a simple little toy plugin that just spits out debugging info..

searls commented 10 years ago

@jraede -- quick update:

  1. I've been behind the eight-ball all week and haven't sat to work on this issue when I said I would.
  2. I actually have decided to de-prioritize releasing this feature just below doing a (similarly complex) lineman plugin for browser testing

My reasoning for the latter is because of #208. If we could get that right, then we could build the entirety of lineman deploy without any additions to lineman core. Perhaps better yet, we could make the deploy behavior overridable by plugins such that the default behavior might be to use the npm module to search npmjs.org for lineman-deploy-* projects and list them out for the user, and each deploy plugin would replace that default instructional behavior.

Thoughts?

jraede commented 10 years ago

Weird, just saw this now. Sure, we could make lineman-deploy a decoupled plugin and keep the functionality. Won't be much development time either way...I guess I'll just keep an eye on 208 and port this over to that API.

searls commented 10 years ago

Yeah, I apologize for putting you at the far end of a dependency chain. The more I think about this feature the more I think I want to let it spend time in the oven. One way to do that would be to start with a plugin before touching core