search

linemanjs / lineman

Lineman helps you build fat-client JavaScript apps. It produces happiness by building assets, mocking servers, running specs on every file change
MIT License
1.18k stars 80 forks source link

Non-compiling coffeescript should fail #227

Closed tandrewnichols closed 9 years ago

tandrewnichols commented 10 years ago

Currently, with client side specs written in coffeescript, if they don't compile, they're simply excluded from the test results, which can be misleading, since it looks like everything is passing. This may not be a lineman issue (maybe testem?), but I thought I'd at least surface it here. It would be nice for non-compiling coffeescript to register as a test failure. Probably a single failure, since there's no way to know the total number of tests in the file since it didn't compile.

searls commented 10 years ago

Does it pass silently on lineman spec-ci? My guess is that it would fail there.

The issue is that lineman run will pass grunt --force by default which keeps chugging even when a failure occurs, and I can't think of a single non-hacky fix for this, short of running lineman run --stack (which undoes --force) when you're testing heavily.

Again, that'll kill the lineman process, your tests will still appear happy. :-/

Short of on-error printing out some failing test into the concatenated sources, I just don't know.

tandrewnichols commented 10 years ago

Or even just being notified that something might have gone wrong would be . . . better. Like on-error console.log (not great, but it'll show up in the testem window at least).