search

lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
MIT License
307 stars 130 forks source link

Country codes. #110

Closed alexfalkowski closed 6 years ago

alexfalkowski commented 6 years ago

Hi,

This is a question regarding the changes in 2.0. When I do 

[1] pry(main)> Peddler::Marketplace.all.map { |m| m.country_code }
=> ["CA", "MX", "US", "BR", "DE", "ES", "FR", "IT", "GB", "IN", "AU", "JP", "CN"]

I no longer have UK but it has been replaced with GB. According to this https://docs.developer.amazonservices.com/en_US/dev_guide/DG_Endpoints.html it should be UK. Was just wondering why the change as this impacts us.

hakanensari commented 6 years ago

Wow, you noticed this 😮

I ended up sticking to standard country codes but added a guard to accommodate UK as well, so all should be good.

alexfalkowski commented 6 years ago

@hakanensari - yes I noticed cause we wrote out own find_by_country_code. Will user your new find then.