search

lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
https://lineofflight.github.io/peddler/
MIT License
307 stars 130 forks source link

"member" replaced by "PrepDetails" #123

Closed yubrew closed 5 years ago

yubrew commented 5 years ago

In Amazon's MWS docs, it shows PrepDetailsList => PrepDetails => etc.

http://docs.developer.amazonservices.com/en_US/fba_inbound/FBAInbound_PreparationExamples.html

&InboundShipmentPlanRequestItems.member.1.SellerSKU=SKU00001
&InboundShipmentPlanRequestItems.member.1.Quantity=1
&InboundShipmentPlanRequestItems.member.1.PrepDetailsList.PrepDetails.1.PrepInstruction=Taping          
&InboundShipmentPlanRequestItems.member.1.PrepDetailsList.PrepDetails.1.PrepOwner=AMAZON
&InboundShipmentPlanRequestItems.member.2.SellerSKU=SKU00002
&InboundShipmentPlanRequestItems.member.2.Quantity=1
&InboundShipmentPlanRequestItems.member.2.PrepDetailsList.PrepDetails.1.PrepInstruction=Labeling         
&InboundShipmentPlanRequestItems.member.2.PrepDetailsList.PrepDetails.1.PrepOwner=AMAZON
&InboundShipmentPlanRequestItems.member.2.PrepDetailsList.PrepDetails.2.PrepInstruction=Taping         
&InboundShipmentPlanRequestItems.member.2.PrepDetailsList.PrepDetails.2.PrepOwner=SELLER
hakanensari commented 5 years ago

@yubrew thanks 👍

hakanensari commented 5 years ago

@yubrew before I release this, could you confirm this works as intended? I now see "member" used in the example code section on this page. One of the two sample codes must be incorrect.

Also, if it's indeed PrepDetails, then we should update the other two actions that use the same attribute.

yubrew commented 5 years ago

Both member and PrepDetails work. I didn't see the other examples using member before submitting this git pull. Let's stick with member.