lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
https://lineofflight.github.io/peddler/
MIT License
307 stars 130 forks source link

Broken See Also docs links #141

Closed janklimo closed 4 years ago

janklimo commented 4 years ago

I randomly stumbled upon a broken docs link in the codebase. I greped the whole codebase for all links referenced after @see and ran a script to check if they work. Here's the full list of the broken ones:

"FAILED: https://docs.developer.amazonservices.com/en_US/orders/2013-09-01/Orders_ListOrders.html"
"FAILED: https://docs.developer.amazonservices.com/en_US/orders/2013-09-01/Orders_ListOrdersByNextToken.html"
"FAILED: https://docs.developer.amazonservices.com/en_US/orders/2013-09-01/Orders_GetOrder.html"
"FAILED: https://docs.developer.amazonservices.com/en_US/orders/2013-09-01/Orders_ListOrderItems.html"
"FAILED: https://docs.developer.amazonservices.com/en_US/orders/2013-09-01/Orders_ListOrderItemsByNextToken.html"
"FAILED: https://docs.developer.amazonservices.com/en_US/orders/2013-09-01/MWS_GetServiceStatus.html"

These are the updated versions:

"https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_ListOrders.html"
"https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_ListOrdersByNextToken.html"
"https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_GetOrder.html"
"https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_ListOrderItems.html"
"https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/Orders_ListOrderItemsByNextToken.html"
"https://docs.developer.amazonservices.com/en_US/orders-2013-09-01/MWS_GetServiceStatus.html"

Maybe something that could be built into the actions pipeline?

hakanensari commented 4 years ago

That’s a fantastic idea. We could also run the check on a schedule. Would you like to take a stab at this?

janklimo commented 4 years ago

Great! I'll open a PR with a working version 👍