lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
MIT License
307 stars 130 forks source link

NotImplementedError #20

Closed wwqrd closed 10 years ago

wwqrd commented 10 years ago

Amazon is returning Content-Type "text", for the listings reports, which are "tab-delimited flat file" format, meaning that calling:

mwsr = MWS::Reports.new
mwsr.get_report(report_id)
# raises `NotImplementedError` in parser.rb

It looks like https://github.com/hakanensari/peddler/blob/master/lib/peddler/parser.rb#L14-21 is intended to handle this?

hakanensari commented 10 years ago

MWS apparently will return a variety of content type headers depending on their internal report implementations. I removed the defensive check on content type, so it should work fine now/

Thanks for posting the issue.

wwqrd commented 10 years ago

I wonder why it does that :smile:

Thank you for the update!