lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
MIT License
307 stars 130 forks source link

Please add FBAInbound_GetUniquePackageLabels. #73

Closed noorani786 closed 7 years ago

noorani786 commented 8 years ago

The API method to retrieve unique package labels is missing. Can you please add?

http://docs.developer.amazonservices.com/en_US/fba_inbound/FBAInbound_GetUniquePackageLabels.html

Thanks!

hakanensari commented 8 years ago

It seems Amazon introduced in this API some new operations, including the two you posted here. It would be great if you took a stab at this with a PR. Otherwise, I'll do so when I get a chance.

noorani786 commented 7 years ago

I have implemented this but getting an accessing denied when trying to push another branch onto your repository so I can create a pull request. Here is the implementation:


      # Returns PDF document data for printing unique package labels for faster and more accurate
      # shipment processing at the Amazon fulfillment center
      #
      # @see http://docs.developer.amazonservices.com/en_US/fba_inbound/FBAInbound_GetUniquePackageLabels.html
      # @param [String] shipment_id
      # @param [String] page_type
      # @param [Array<String>] package_labels_to_print
      # @return [Peddler::XMLParser]
      def get_unique_package_labels(shipment_id, page_type, package_labels_to_print)
        operation('GetUniquePackageLabels')
          .add('ShipmentId' => shipment_id,
               'PageType' => page_type,
               'PackageLabelsToPrint' => package_labels_to_print
          )
          .structure!('PackageLabelsToPrint', 'member')

        run
      end
hakanensari commented 7 years ago

but getting an accessing denied when trying to push another branch onto your repository so I can create a pull request

I'm not sure if this is what the issue is, but you will want to clone the repository to your own account and push there. Then, you can create a pull request through the site.

The code looks good. It would be great if you could also fill the tests here and here.

cc: #74