search

lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
MIT License
307 stars 130 forks source link

New Parameter for SubmitFeed #77

Closed machineboy2045 closed 7 years ago

machineboy2045 commented 7 years ago

I got a notice from Amazon recently:

Amazon Marketplace Web Service (Amazon MWS) is announcing a change to how MD5 hashes work for the SubmitFeed operation in the Feeds service. Previously, the MD5 hash for the incoming feed data was carried in the Content-MD5 header. This still works for backward compatibility, but we recommend passing the hash value using the ContentMD5Value parameter of SubmitFeed. This new parameter is available worldwide. When you pass the MD5 hash as a parameter, the value of the hash will be computed as part of the digital signature when submitting a feed. This will allow MWS to detect if the value has been modified in transit. GetFeedSubmissionResult still uses the Content-MD5 header as before. This change is reflected in the latest version of the Feeds client libraries, which you can download in the following languages: Java C# PHP

It says the change will be backwards compatible, so I assume peddler will keep working without an update. But I thought I'd post this just in case. :)

hakanensari commented 7 years ago

@machineboy2045 I will reopen. Being short of time, I had originally :+1:'ed the issue instead of replying, which probably was not very communicative.

Yes, let's implement this. Would you like to take a stab?

machineboy2045 commented 7 years ago

Haha. No worries. I might take a stab but no promises. :P

On Tue, Nov 8, 2016 at 3:54 AM, Hakan Ensari notifications@github.com wrote:

@machineboy2045 https://github.com/machineboy2045 I will reopen. Being short of time, I had originally đź‘Ť'ed the issue instead of replying, which probably was not very communicative.

Yes, let's implement this. Would you like to take a stab?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hakanensari/peddler/issues/77#issuecomment-259117781, or mute the thread https://github.com/notifications/unsubscribe-auth/AD5fc2NcwM6spaDJmKr3lCqtdm52XHB6ks5q8GL5gaJpZM4KTEvU .

noorani786 commented 6 years ago

Did you guys get a chance to work on this? Amazon is now throwing errors on this for the _POST_FLAT_FILE_PRICEANDQUANTITYONLY_UPDATEDATA

hakanensari commented 6 years ago

Yep, see linked commit above

noorani786 commented 6 years ago

Sorry just not familiar with GitHub I guess. I am only seeing config file changes:

screen shot 2018-02-22 at 3 49 27 pm
hakanensari commented 6 years ago

You got me there. I actually implemented this in a dependency:

https://github.com/hakanensari/jeff/commit/d3a8d35eeaf41f279665a6fa42636aa1b8229d76

I'll also change the version requirement for Jeff to reflect this, now that the deprecated header no longer works.

noorani786 commented 6 years ago

Got it. Thanks!

On Thu, Feb 22, 2018 at 4:00 PM, Hakan Ensari notifications@github.com wrote:

You got me there. I actually implemented this in a dependency:

hakanensari/jeff@d3a8d35 https://github.com/hakanensari/jeff/commit/d3a8d35eeaf41f279665a6fa42636aa1b8229d76

I'll also change the version requirement for Jeff to reflect this, now that the deprecated header no longer works.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hakanensari/peddler/issues/77#issuecomment-367836944, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYXrMuw6uCnMf-eiXfLdo92jzp2e74Kks5tXeNvgaJpZM4KTEvU .