search

lineofflight / peddler

Amazon Selling Partner API (SP-API) in Ruby
https://lineofflight.github.io/peddler/
MIT License
307 stars 130 forks source link

quota headers #80

Closed chrishough closed 7 years ago

chrishough commented 7 years ago

According to AWS Throttling the following headers should come over with each request.

x-mws-quota-max: 3600
x-mws-quota-remaining: 10
x-mws-quota-resetsOn: Wed, 06 Mar 2013 19:07:58 GMT

Have these been removed from this gem?

hakanensari commented 7 years ago

They haven't been removed, as in they're there in the header, but we're not really exposing them in the crafted response.

Making this data more accessible could be a future improvement.

chrishough commented 7 years ago

Awesome! I think passing them through would be more supportive of a API service layer. Would it be cool if I sent you a PR for this?

hakanensari commented 7 years ago

Absolutely :cool:

chrishough commented 7 years ago

Thank you. Sorry I have not had more time to work on this. I still have the other issue pending for verification.