Implement the `has_pending_changes` feature for the views - Githubissues

linera-io / linera-protocol

Main repository for the Linera protocol

Apache License 2.0

112 stars 94 forks source link

Implement the `has_pending_changes` feature for the views #2202

Open MathieuDutSik opened 4 days ago

MathieuDutSik commented 4 days ago

Motivation

The has_pending_changes has been mentioned as a nice-to-have feature for the views. This implements it.

Proposal

The following was done:

The has_pending_changes has been implemented.
It has to be async since one has to access updates that are protected under a Mutex.
It does not return errors, which is nice.
Another correction for the hashable_wrapper has been done.
Tests have been added to the containers.

Test Plan

The tests have been improved to test the feature.

Release Plan

The feature will need to be added to the documentation.

Links

reviewer checklist

ma2bd commented 4 days ago

Thanks. I think I still prefer the initially-suggested name "has_pending_changes"

MathieuDutSik commented 4 days ago

Thanks. I think I still prefer the initially-suggested name "has_pending_changes"

Ok, renamed.