search

linera-io / linera-protocol

Main repository for the Linera protocol
Apache License 2.0
1.05k stars 144 forks source link

Track new chains in node service even if notifications were skipped. #941

Open afck opened 1 year ago

afck commented 1 year ago

Currently the chain listener only adds a newly opened chain to the wallet if it receives a NewBlock notification for the block that created it. But there is no guarantee that this will happen: If the next block's notification is processed first, the lower block's notification is filtered out.

ma2bd commented 1 year ago

As discussed we may want to replace this NewBlock introspection code with a proper execution callback on the local node.

afck commented 11 months ago

This issue could be considered closed after https://github.com/linera-io/linera-protocol/pull/1183: We're using local notifications now, so no NewBlock notification will be skipped.

But we still do the NewBlock introspection.