lineupjs / lineup_htmlwidget

HTMLWidget wrapper of LineUp for Visual Analysis of Multi-Attribute Rankings
https://lineup.js.org
Other
54 stars 9 forks source link

Purpose of small arrows and how to turn them off #8

Closed nevrome closed 6 years ago

nevrome commented 6 years ago

Thanks for this really nice widget!

What's the purpose of these small up and down arrows that accompany every cell?

screenshot_2018-10-12_16-41-51

How can I turn them off if they don't serve any purpose for me?

sgratzl commented 6 years ago

those are tiny scrollbars. We don't know yet why on some systems and configurations they appear and in others they won't. However, increasing the height of an individual row usually fixed the problem.

can you try to run something like:

lineup(shared_iris, options=list(rowHeight=20))
nevrome commented 6 years ago

Thanks for the fast reply. Unfortunately rowHeight doesn't seem to do anything. I can't see any effect of this option.

The arrows do not appear if I use lineupjs::lineup independently. The problem seems to be limited to the context of my shiny app. There I have some custom CSS to make some parts of the lineup table transparent.

.lu-row {
  background-color: rgba(0,0,0,0.0) !important;
}
.lu-header {
  background-color: rgba(0,0,0,0.0) !important;
}
.lu-handle {
  background-color: rgba(0,0,0,0.0) !important;
}

But I guess that's not the problem.

nevrome commented 6 years ago

I was able to set the row height manually in my CSS:

.lu-row {
  background-color: rgba(0,0,0,0.0) !important;
  height: 20px !important;
}

That worked and solved the scrollbar problem. Thanks for your help!

sgratzl commented 6 years ago

.lu-row { background-color: rgba(0,0,0,0.0) !important; height: 20px !important; }

please avoid setting the height manually. LineUp needs to know what the row height is since it optimized the rendering to show only the visible rows. With this approach you might end up with scrolling articfacts. You can try to set overflow: hidden !important instead;

nevrome commented 6 years ago

Hm... I understand. overflow: hidden !important doesn't work for me.

Do you have an idea why the rowHeight option has no effect? In the R help ?lineup this option is not explicitly documented. Maybe it's not implemented yet on the R site?

sgratzl commented 6 years ago

there was a bug when merging the default options with the given options. Fixed with https://github.com/datavisyn/lineup_htmlwidget/commit/39a9acbf329105de614b4de225457e19b6d05edf. Moreover, I updated to lineupjs 3.1.5

lineup(iris, options=list(rowHeight=40))

results now in

image

nevrome commented 6 years ago

Excellent! Thank you very much!