search

lineupjs / lineup_widget

Jupyter Widget wrapper for Lineup.js
https://lineup.js.org
BSD 3-Clause "New" or "Revised" License
12 stars 6 forks source link

bump min widgets version for jlab2 #8

Closed timkpaine closed 4 years ago

sgratzl commented 4 years ago

I just released a new version with lineupjs v4.0 which should be compatible.

timkpaine commented 4 years ago

This is still going to break for people when used in conjunction with other libraries unless you support 3 as well. E.g. the official sidecar library will cause your latest release to break https://github.com/jupyter-widgets/jupyterlab-sidecar/blob/master/package.json#L41

I recommend ^2 || ^3 || ^4 for maximum compatibility.

sgratzl commented 4 years ago

atm it looks like that:

https://github.com/lineupjs/lineup_widget/blob/c158f1467b5b1251b7a57a4bb5c570421dd2c3e8/js/package.json#L47

which works for me in another project

timkpaine commented 4 years ago

It causes my installation to break due to jupyter-widgets/base 3 being the resolved version.

sgratzl commented 4 years ago

I tried to follow the same pattern as I used to do in another project: https://github.com/upsetjs/upsetjs_jupyter_widget/#installation. Have you tried to install the manager manually before?

timkpaine commented 4 years ago

I have about 40 extensions in my deployment, I have the latest non-alpha jupyterlab manager (2.0.0). I have lineup_widget installed from my fork for now which works fine, and the extension system for JupyterLab is consolidating to hopefully alleviate this problem anyway.