Closed thinkh closed 3 years ago
The linter seems to have a conditions that exclude each other. If I commit the following Prettier output (formatting on save) ...
@mixin collapsing-row-border($border-width, $border-color) {
// use box-shadow to create collapsing border (@see https://stackoverflow.com/a/28807765)
box-shadow: $border-width 0 0 0 $border-color, 0 $border-width 0 0 $border-color,
$border-width $border-width 0 0 $border-color /* Just to fix the corner */, $border-width 0 0 0 $border-color inset,
0 0 0 $border-width $border-color;
}
... the linter complains:
Checking formatting...
All matched files use Prettier code style!
src/styles/_mixins.scss
3:48 ✖ Expected newline after "," in a multi-line list value-list-comma-newline-after
4:79 ✖ Expected newline after "," in a multi-line list value-list-comma-newline-after
Error: Process completed with exit code 2.
Putting every part in the new line like so...
@mixin collapsing-row-border($border-width, $border-color) {
// use box-shadow to create collapsing border (@see https://stackoverflow.com/a/28807765)
box-shadow: $border-width 0 0 0 $border-color,
0 $border-width 0 0 $border-color,
$border-width $border-width 0 0 $border-color /* Just to fix the corner */,
$border-width 0 0 0 $border-color inset,
0 0 0 $border-width $border-color;
}
... returns the following error:
Checking formatting...
[warn] src/styles/_mixins.scss
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
Error: Process completed with exit code 1.
@sgratzl How should I proceed here? Can we either change Prettier or the stylelint config?
@sgratzl How should I proceed here? Can we either change Prettier or the stylelint config?
I would change the stylelint config
Fixes lineupjs/lineupjs#456
Summary