lineupjs / lineupengine

fast scalable table renderer
https://lineupengine.js.org
MIT License
4 stars 0 forks source link

Run-time errors after release of v2.4.1 #56

Closed thinkh closed 2 years ago

thinkh commented 2 years ago

LineUp breaks in our apps after the release 2.4.1 with the following run-time error:

Uncaught (in promise) TypeError: Class constructor ACellTableSection cannot be invoked without 'new'
    at new EngineRanking (EngineRanking.js:71:1)
    at MultiTableRowRenderer.<anonymous> (EngineRenderer.js:277:1)
    at MultiTableRowRenderer.pushTable (MultiTableRowRenderer.js:107:1)
    at EngineRenderer.push.6NJj.EngineRenderer.addRanking (EngineRenderer.js:276:1)
    at Object.<anonymous> (EngineRenderer.js:225:1)
    at Dispatch.apply (dispatch.js:61:59)
    at fireImpl (AEventDispatcher.js:107:1)
    at Array.forEach (<anonymous>)
    at LocalDataProvider.push.gwz5.AEventDispatcher.fireImpl (AEventDispatcher.js:110:1)
    at LocalDataProvider.push.gwz5.AEventDispatcher.fire (AEventDispatcher.js:84:1)

image

I think the error is caused by the updated tsconfig.json. We should revert/downgrade version and match the one in lineupjs.

https://github.com/lineupjs/lineupengine/blob/7f7a197a5d026113a0de2f18476c909ba49623c7/tsconfig.json#L2-L7

https://github.com/lineupjs/lineupjs/blob/93e18c26a61797342b4953a2d6b6a9558ce4a177/tsconfig.json#L3-L7

    "module": "ES2015",
    "target": "ES5",
    "importHelpers": false,
    "sourceMap": true,
    "lib": ["DOM", "ES2015", "es2016.array.include", "es2017.object"],

Please create another patch release after this fix.

Context