lineuve / u8glib

Automatically exported from code.google.com/p/u8glib
0 stars 0 forks source link

UC1610 with atmega_hw_spi #60

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
In the declaration of the u8g_dev_uc1610_dogxl160_XX_XX_spi devices, instead of 
the U8G_COM_SW_SPI or U8G_COM_HW_SPI macros arduino functions are being called 
( u8g_com_arduino_sw_spi_fn and u8g_com_arduino_hw_spi_fn ). This results bad 
spi communication. 
The suggested correct lines on the end of u8g_dev_uc1610_dogxl160.c :
U8G_PB_DEV(u8g_dev_uc1610_dogxl160_bw_sw_spi, WIDTH, HEIGHT, 8, 
u8g_dev_uc1610_dogxl160_bw_fn, U8G_COM_SW_SPI);
U8G_PB_DEV(u8g_dev_uc1610_dogxl160_bw_hw_spi, WIDTH, HEIGHT, 8, 
u8g_dev_uc1610_dogxl160_bw_fn, U8G_COM_HW_SPI);

U8G_PB_DEV(u8g_dev_uc1610_dogxl160_gr_sw_spi, WIDTH, HEIGHT, 4, 
u8g_dev_uc1610_dogxl160_gr_fn, U8G_COM_SW_SPI);
U8G_PB_DEV(u8g_dev_uc1610_dogxl160_gr_hw_spi, WIDTH, HEIGHT, 4, 
u8g_dev_uc1610_dogxl160_gr_fn, U8G_COM_HW_SPI);

Original issue reported on code.google.com by velinszk...@gmail.com on 27 Mar 2012 at 5:17

GoogleCodeExporter commented 8 years ago
Excellent observation. Thanks a lot for the bug report.

Note: Only AVR variant affected.

Original comment by olikr...@gmail.com on 27 Mar 2012 at 7:07