search

ling-ui / pe

0 stars 0 forks source link

Missing constructor for UML #15

Open ling-ui opened 1 year ago

ling-ui commented 1 year ago

image.png

image.png

DeleteCommandParser calls for the creation of a new DeleteCommand object using the DeleteCommand() constructor and creation of an EmployeeId object, but the constructor method and the new EmployeeId object part is not reflected in the diagram.

soc-se-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Hi there! Thanks so much for the report.

We intentionally left this detail out of the diagram as we did not want to overcomplicate the UML diagram given that the key details of the DeleteCommand is already portrayed in the diagram. Adding the details of the construction of EmployeeID can potentially confuse users.

Once again, thank you so much for informing us regarding the error.

Cheers,
Coydir
HR is hard, Coydir is easy
(est. 2022)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]