search

linghu8812 / tensorrt_inference

696 stars 205 forks source link

NMSDetect in ScaledYOLOV4 is different from original one #22

Open bobbilichandu opened 3 years ago

bobbilichandu commented 3 years ago

NMSdetect that was written in ScaledYOLOV4.cpp is different from the original one. It is implemented in O(n^2) complexity, any reason for that? And how is it different from the original code?

linghu8812 commented 3 years ago

https://github.com/AlexeyAB/darknet/blob/master/src/box.c#L746-L755

bobbilichandu commented 3 years ago

I mean the one in scaled_yolov4.

linghu8812 commented 3 years ago

original scaled_yolov4 is pytorch, this is C++, so refer yolov4.

bobbilichandu commented 3 years ago

Ok got it! Is there any python implementation for 'refermatrix generation' and 'anchor part in post processing'. I am trying to convert your c++ code to python, but there are some issues I am facing. with post processing and NMS.

bobbilichandu commented 3 years ago

@linghu8812 can we connect over discord https://discordapp.com/users/chandu_sai_007#8966 or mail(chandutargaryen@gmail.com)

linghu8812 commented 3 years ago

I don't have discord, my email is linghu8812@163.com.

to see refer matrix, just add:

std::cout << refer_matrix << std::endl;`

above this line: https://github.com/linghu8812/tensorrt_inference/blob/887cca1487395cc46a23537213201d224600a976/ScaledYOLOv4/ScaledYOLOv4.cpp#L34