lingo / sublime-fscompletion

Auto-complete paths and filenames from the filesystem, à la Ctrl-X,Ctrl-F in VIM
GNU General Public License v3.0
31 stars 5 forks source link

Improved the auto-completion #3

Closed fikovnik closed 11 years ago

fikovnik commented 11 years ago

Hi,

I changed a bit the way the plugin works mostly to support following:

I did a bit of a testing, but some real tests are missing. Let me know if you want to pull in these changes or if I shall make a new plugin.

/cheers Filip

lingo commented 11 years ago

Hi there, sorry for the slow reply -- I've been too busy using Sublime to actually work on plugins.

This work looks great! I've just go to test a bit more, but I think I'll pull this in with pleasure in the next day or two.

Je te dirai merci, en voyant que tu vives en France!

fikovnik commented 11 years ago

Hi!

After using it for a while I fixed some more issues. Right now it does what I need. Next time I start doing something like this I will start with the spec first :-)

lingo commented 11 years ago

Ah, thanks. I had noticed your last version wasn't working for me, but I haven't had time to bugfix. Checking now...

lingo commented 11 years ago

Traceback (most recent call last): File "./sublime_plugin.py", line 236, in on_query_completions File "./fscompletion.py", line 57, in on_query_completions NameError: global name 'getviewcwd' is not defined

fikovnik commented 11 years ago

Hi,

Right, I see, this is because I never restarted Sublime so the reloading of plugins reloads existing definition, but does not remove the ones that were removed in the files themselves (something like issuing new import statement in python REPL).

Should be now fixed (it did affected some other parts).

Thanks a lot for feedback!

lingo commented 11 years ago

Thanks for your work on this. However, I still can't really get this working on my machine, so reviewing.

fikovnik commented 11 years ago

Hi,

Could you a bit more specific? I just tried a clean launch and works fine. but perhaps I miss something. I will try to do some unites for the plugin.

Thanks!

chestozo commented 11 years ago

Works fine for me. Also thanks for completion from the root project directory )