search

lingpy / pybor

A Python library for borrowing detection based on lexical language models
Apache License 2.0
3 stars 1 forks source link

Logging change for some, output change for some. #32

Closed fractaldragonflies closed 4 years ago

fractaldragonflies commented 4 years ago

cross_validation_models_example - log change and output change. donor_table_explore - output change only. App did not use logging directly. neural_entropies_example - output change only. App did not use logging directly. neural_example - neither used fakeborrowings - file prefix needed for my OS others did not use either logging directly or create output.

LinguList commented 4 years ago

BTW: fine with me, so feel free to merge.

tresoldi commented 4 years ago

Fine by me as well, feel free to merge, @fractaldragonflies . I might suggest a couple of changes later, but won't mess with the PR now.

On the matter of the shebang, I am actually in favor of having it, also considering it is recommended by PEP 394 and 486. True, the reason is mostly to deal with Python 2/3 issues that don't apply to us, but it still seems a good Unix practice.