search

lingthio / Flask-User

Customizable User Authorization & User Management: Register, Confirm, Login, Change username/password, Forgot password and more.
http://flask-user.readthedocs.io/
MIT License
1.06k stars 292 forks source link

Fix example code for CustomUserManager.customize #205

Closed bbc2 closed 6 years ago

bbc2 commented 6 years ago

That makes the example consistent with what can be read on the following page of documentation: https://flask-user.readthedocs.io/en/latest/customizing_forms.html#customizing-form-classes

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c03fdf7). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #205   +/-   ##
=========================================
  Coverage          ?   90.49%           
=========================================
  Files             ?       25           
  Lines             ?     1452           
  Branches          ?        0           
=========================================
  Hits              ?     1314           
  Misses            ?      138           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c03fdf7...7e1343d. Read the comment docs.

lingthio commented 6 years ago

Thank you!

lingthio commented 6 years ago

Headsup: the field name "self.register_form" does not indicate it's pointing to a class rather than an instance. I'm going to fix this by renaming all class attributes to something like: self.RegisterFormClass. This change will take effect in the next v1.0.1.3 release.