jasonehines commented 5 years ago

This is working. I've tried to document things but I'm not really familiar with restructuredtext, so I may have missed something.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a379fa0). Click here to learn what that means. The diff coverage is 43.37%.

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage          ?   85.66%           
=========================================
  Files             ?       26           
  Lines             ?     1605           
  Branches          ?        0           
=========================================
  Hits              ?     1375           
  Misses            ?      230           
  Partials          ?        0

Impacted Files	Coverage Δ
flask_user/user_manager__settings.py	`100% <100%> (ø)`
flask_user/forms.py	`98.21% <100%> (ø)`
flask_user/db_manager.py	`87.69% <100%> (ø)`
flask_user/__init__.py	`100% <100%> (ø)`
flask_user/user_manager__views.py	`77.6% <13.09%> (ø)`
flask_user/totp_manager.py	`47.82% <47.82%> (ø)`
flask_user/user_manager__utils.py	`87.87% <60%> (ø)`
flask_user/user_manager.py	`88.83% <69.56%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a379fa0...a59e690. Read the comment docs.

jasonehines commented 5 years ago

I haven't written test before, so it might be awhile before I can add them.

abirke commented 5 years ago

I think it's a great idea to implement 2FA in flask-user. :+1: As far as I can see,

onetimepass and
pyqrcode

should be added to _installrequires in setup.py then.

jasonehines commented 5 years ago

I'm not sure when I will have time to tackle the tests for this.

lingthio / Flask-User

Time-based One Time Passwords #256

Codecov Report