Fix crash on user comparison when password is None

lingthio / Flask-User

Customizable User Authorization & User Management: Register, Confirm, Login, Change username/password, Forgot password and more.

http://flask-user.readthedocs.io/

MIT License

1.06k stars 294 forks source link

Closed rubenwardy closed 4 years ago

rubenwardy commented 4 years ago

I have the password field set to None when users create accounts using services like Github

Related: #104

This may be the wrong fix - is it safe and preferable to use the empty string for the password when a user cannot log in using a password?

rubenwardy commented 4 years ago

The tutorials have "" as a default string for password, so I guess changing my code would be better?

rubenwardy commented 4 years ago

The login form verifies the password isn't empty, and I found a note in data_models.rst that the password is required