lingua-libre / BlueLL

🌻 MediaWiki skin used by LinguaLibre.org
BSD 2-Clause "Simplified" License
6 stars 4 forks source link

Fatal error: Uncaught Error: Call to undefined function wfSuppressWarnings() in BlueLL #2

Closed noloader closed 3 years ago

noloader commented 3 years ago

Hi Everyone,

I help run the Crypto++ website and wiki at https://www.cryptopp.com. Our Mediawiki version is 1.34. Also see Special:Version.

I attempted to add BlueLL to the skins. Previewing BlueLL results in:

Fatal error: Uncaught Error: Call to undefined function wfSuppressWarnings() in
/var/www/html/w/skins/BlueLL/BlueLL.skin.php:34 Stack trace: #0 /var/www/html/w/
includes/skins/SkinTemplate.php(217): BlueLLTemplate->execute() #1 /var/www/html
/w/includes/OutputPage.php(2574): SkinTemplate->outputPage() #2 /var/www/html/w/
includes/exception/MWExceptionRenderer.php(134): OutputPage->output() #3 /var/ww
w/html/w/includes/exception/MWExceptionRenderer.php(53): MWExceptionRenderer::re
portHTML(Object(Error)) #4 /var/www/html/w/includes/exception/MWExceptionHandler
.php(121): MWExceptionRenderer::output(Object(Error), 2) #5 /var/www/html/w/incl
udes/exception/MWExceptionHandler.php(195): MWExceptionHandler::report(Object(Er
ror)) #6 /var/www/html/w/includes/exception/MWExceptionHandler.php(167): MWExcep
tionHandler::handleException(Object(Error)) #7 [internal function]: MWExceptionH
andler::handleUncaughtException(Object(Error)) #8 {main} thrown in /var/www/html
/w/skins/BlueLL/BlueLL.skin.php on line 34

The result came from a clone the BlueLL GitHub. I noticed there are no tagged releases, like REL1_34 and REL1_35. Most Mediawiki skins and extensions provide a tagged release. For example, our update script does a git checkout master -f && git pull followed by a git checkout REL1_34.

Here's what it looks like with BlueLL. Notice BlueLL produces an error pathspec 'REL1_34' did not match any file(s) known to git.

# ./update-wiki.sh
...
Updating /var/www/html/w/skins/CologneBlue/
HEAD is now at 7a30ed7 Localisation updates from https://translatewiki.net.
Already up-to-date.
Already on 'REL1_34'
Updating /var/www/html/w/skins/Vector/
HEAD is now at f39a3f0 vector.js: Remove eager calculation of p-cactions width on page load
Already up-to-date.
Already on 'REL1_34'
Updating /var/www/html/w/skins/BlueLL/
HEAD is now at 9757eb8 T196759: add support for the echo  MW extension
Already up-to-date.
error: pathspec 'REL1_34' did not match any file(s) known to git.
Updating /var/www/html/w/skins/Nimbus/
HEAD is now at 1f1d8a1 Localisation updates from https://translatewiki.net.
Already up-to-date.
Already on 'REL1_34'
...

Also see this issue report for the Pivot Skin. The report says:

The global function `wfSuppressWarnings` was deprecated since 1.26 and now removed. The skin must be updated to use "*.`Wikimedia\AtEase\AtEase::suppressWarnings()

Also see Pivot Skin Pull Request #90.

I'm guessing that means BlueLL is only available for Mediawiki 1.20 - 1.33. Mediawiki 1.34 and higher is not supported.