search

lingua-libre / BlueLL

🌻 MediaWiki skin used by LinguaLibre.org
BSD 2-Clause "Simplified" License
6 stars 4 forks source link

Make compatible with 1.35 #3

Closed jdlrobson closed 3 years ago

jdlrobson commented 3 years ago

There are a few exceptions in 1.35 fixed with these small adjustments. I would like to showcase this on https://skins.wmflabs.org

Fixes: #2

FYI since the skin is not working at time of writing I've also temporarily marked the skin as "unmaintained" on https://www.mediawiki.org/wiki/Skin:BlueLL . Please mark it as stable as soon as this patch is merged.

hugolpz commented 3 years ago

@jdlrobson : so you tested these Skin fixes on a mediawiki you upgraded to 1.35, right ? We (LL's volunteers) are now discussing accepting your fix. But we have a limited ability to evaluate your work and the risks since we never worked on skins. We do plan to migrate to 1.35+ in March.

Could you comment on this change : here ?

jdlrobson commented 3 years ago

The patch is deployed here: https://skins-demo.wmflabs.org/?useskin=bluell Without the patch the skin displays a blank screen which should be easy to verify by installing MediaWiki 1.35 and cloning the repo in the skins folder.

No worries about the delay. No expectations my side around timing.

hugolpz commented 3 years ago

@Seb35, i believe you have a local instance of LinguaLibre on your PC right ? Could you 1) review this PR, 2) test it on your local instance and 3) validate-merge it when confident enough ?

Seb35 commented 3 years ago

Yes, I installed a local instance on my PC. I tested quickly this PR this afternoon and it works well on 1.35 together with the updated extension Custom Subtitle. I see @jdlrobson did a very good job with even the check about RecordWizard for non-LinguaLibre wikis :-) I just review it a bit more extensively next week, particularly to be sure it works on MW 1.31 to deploy it together with upcoming changes from #5.

hugolpz commented 3 years ago

Merged. Thank to you both for this work and review. 🧑🏼‍🤝‍🧑🏼 🤝