Made the texts in the shortcuts popup translatable

lingua-libre / RecordWizard

🌻 MediaWiki extension allowing mass recording of clean, well cut, well named pronunciation files.

https://lingualibre.org

GNU General Public License v2.0

15 stars 3 forks source link

Made the texts in the shortcuts popup translatable #7

Closed Poslovitch closed 3 years ago

Poslovitch commented 3 years ago

(Partly) fixes https://phabricator.wikimedia.org/T215055#6881548.

I have no idea how translatewiki works - can this PR be merged right now and will TranslateWiki automatically "update" itself with the new entries, or do we have additional steps to follow.

Aside from this, this PR should not require tests. It's pretty straightforward.

hugolpz commented 3 years ago

Just editing translation file. I quicky checked by eyes if I could see any typo. Were you able to check the js, mustache format are valid and no typo there ?

Should we merge ?

Poslovitch commented 3 years ago

There are no changes to any JS files, and there shouldn't be any issues with the mustache file. It "should" work, because {{_ }} is used this way throughout the whole code.

hugolpz commented 3 years ago

As we say in French : "Ça se tente".