search

lingui / eslint-plugin

Set of ESLint rules for Lingui projects
https://www.npmjs.com/package/eslint-plugin-lingui
MIT License
21 stars 7 forks source link

ci: set up coverage, add the release and lint PR title workflows #11

Closed andrii-bodnar closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@f35252b). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #11 +/- ## ======================================= Coverage ? 95.20% ======================================= Files ? 10 Lines ? 438 Branches ? 135 ======================================= Hits ? 417 Misses ? 21 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timofei-iatsenko commented 1 year ago

I thought about implementing something from here https://github.com/semantic-release/semantic-release to fully automate github tags / releases creation together with changelist.

andrii-bodnar commented 1 year ago

It would be nice to have fully automated releases. For most projects I use the release-it tool, this is also a good option

timofei-iatsenko commented 1 year ago

Let's do whatever you're more familiar with

timofei-iatsenko commented 1 year ago

One more question, with release-it shouldn't we force all commit messages to be conventional commit? Or only PR titile which would be a source of merge commit name?

Honestly, i prefer all commits to be a conventional commits. Looks like it's more popular solution then validating a PR title

andrii-bodnar commented 1 year ago

@thekip It won't force all commit messages to be conventional, but if to allow only squash merging + lint PR title - we will have only conventional commits in the main